[ML] Fix Transform upgrade test #132995

davidkyle · 2025-08-15T15:59:38Z

The test failed comparing an int to a long

elasticsearchmachine · 2025-08-15T16:00:03Z

Pinging @elastic/ml-core (Team:ML)

davidkyle · 2025-08-19T09:54:12Z

...src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java


        // do not allow in mixed clusters
-        if (TransportVersionUtils.isMinTransportVersionSameAsCurrent(state) == false) {
+        if (state.nodes().isMixedVersionCluster()) {


The upgrade test failed because the original check for a mixed cluster isMinTransportVersionSameAsCurrent depends on the order in which the nodes are upgraded. If the master node this code runs on has not been upgraded yet the test will pass.

.../qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/TransformSurvivesUpgradeIT.java

davidkyle · 2025-10-03T15:01:18Z

The upgrade tests from 8.19.5 are failing because the transform upgrade code is fighting it out with the automatic system index upgrader.

First the system index migrator moves .transform-internal-007 to .transform-internal-007-reindexed-for-10

[2025-10-03T10:31:34,304][INFO ][o.e.s.t.SystemIndexMigrator] [v8.19.5-0] preparing to migrate old index [.transform-internal-007] from feature [transform] to new index [.transform-internal-007-reindexed-for-10]
[2025-10-03T10:31:34,305][INFO ][o.e.s.t.SystemIndexMigrator] [v8.19.5-0] migrating index [.transform-internal-007] from feature [transform] to new index [.transform-internal-007-reindexed-for-10]
[2025-10-03T10:31:34,305][INFO ][o.e.s.t.SystemIndexMigrator] [v8.19.5-0] creating new system index [.transform-internal-007-reindexed-for-10] from feature [transform]
[2025-10-03T10:31:34,312][INFO ][o.e.c.m.MetadataCreateIndexService] [v8.19.5-0] creating index [.transform-internal-007-reindexed-for-10] in project [default], cause [migrate-system-index], templates [], shards [1]/[1]
[2025-10-03T10:31:34,386][INFO ][o.e.c.m.MetadataIndexStateService] [v8.19.5-0] adding [index.blocks.write] block to indices [[.transform-internal-007/_WTe27ThRGS_FRhiiZKK3A]]
[2025-10-03T10:31:34,450][INFO ][o.e.c.m.MetadataIndexStateService] [v8.19.5-0] completed adding [index.blocks.write] block to indices [.transform-internal-007]
[2025-10-03T10:31:34,540][INFO ][o.e.c.m.MetadataDeleteIndexService] [v8.19.5-0] [.transform-internal-007/_WTe27ThRGS_FRhiiZKK3A] deleting index
[2025-10-03T10:31:34,586][INFO ][o.e.s.t.SystemIndexMigrator] [v8.19.5-0] Successfully migrated old index [.transform-internal-007] to new index [.transform-internal-007-reindexed-for-10] from feature [transform]

Then POST /_transform/_upgrade is called the final act of which is to delete old indices and because it does not recognise .transform-internal-007-reindexed-for-10 that is deleted too.

[2025-10-03T10:31:40,876][INFO ][o.e.x.t.a.TransportUpgradeTransformsAction] [v8.19.5-0] [mixed-complex-transform] Updated transform [NONE]
[2025-10-03T10:31:40,878][INFO ][o.e.c.m.MetadataDeleteIndexService] [v8.19.5-0] [.transform-internal-007-reindexed-for-10/m6txlkEcTjCPy1jRR3Rk_A] deleting index
/* The new system index has just been deleted !! */
[2025-10-03T10:31:40,918][INFO ][o.e.x.t.a.TransportUpgradeTransformsAction] [v8.19.5-0] Successfully upgraded all transforms, (updated: [0], no action [7])

davidkyle · 2025-10-06T08:15:28Z

@prwhelan I've added 84329e4 to address the rolling upgrade failure described above. Please can you take another look

prwhelan · 2025-10-06T13:00:51Z

...src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java


        // do not allow in mixed clusters
-        if (TransportVersionUtils.isMinTransportVersionSameAsCurrent(state) == false) {
+        if (state.nodes().isMixedVersionCluster()) {


(cherry picked from commit 208ae57) # Conflicts: # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java

(cherry picked from commit 208ae57) # Conflicts: # muted-tests.yml # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java

davidkyle · 2025-10-10T12:26:53Z

💚 All backports created successfully

Status	Branch	Result
✅	9.2
✅	9.1
✅	9.0
✅	8.19
✅	8.18

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 208ae57) # Conflicts: # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java

* [ML] Fix and unmute Transform upgrade test (#132995) (cherry picked from commit 208ae57) # Conflicts: # muted-tests.yml # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java * Update TransformSurvivesUpgradeIT.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>

* [ML] Fix and unmute Transform upgrade test (#132995) (cherry picked from commit 208ae57) # Conflicts: # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java * Update TransformSurvivesUpgradeIT.java * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>

* [ML] Fix and unmute Transform upgrade test (#132995) (cherry picked from commit 208ae57) # Conflicts: # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java * [CI] Auto commit changes from spotless * fix --------- Co-authored-by: elasticsearchmachine <[email protected]>

* [ML] Fix and unmute Transform upgrade test (#132995) (cherry picked from commit 208ae57) # Conflicts: # muted-tests.yml # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java * Update TransformSurvivesUpgradeIT.java * [CI] Auto commit changes from spotless * fix * f --------- Co-authored-by: elasticsearchmachine <[email protected]>

* [ML] Fix and unmute Transform upgrade test (#132995) (cherry picked from commit 208ae57) # Conflicts: # muted-tests.yml # x-pack/plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransportUpgradeTransformsAction.java * Update TransformSurvivesUpgradeIT.java * [CI] Auto commit changes from spotless * fix --------- Co-authored-by: elasticsearchmachine <[email protected]>

Compare int to int

348a45c

davidkyle added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform v9.2.0 labels Aug 15, 2025

elasticsearchmachine added the Team:ML Meta label for the ML team label Aug 15, 2025

Merge branch 'main' into fix-transform-upgrade

c6fba0f

davidkyle enabled auto-merge (squash) August 19, 2025 09:00

use proper mixed version check

53545b9

davidkyle commented Aug 19, 2025

View reviewed changes

davidkyle and others added 3 commits August 19, 2025 15:21

WIP need to check version

56c99e1

skip mixed cluster in older versions

69cae2c

[CI] Auto commit changes from spotless

7faea1b

prwhelan approved these changes Aug 19, 2025

View reviewed changes

DonalEvans reviewed Aug 19, 2025

View reviewed changes

.../qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/TransformSurvivesUpgradeIT.java Show resolved Hide resolved

Merge branch 'main' into fix-transform-upgrade

a30b209

elasticsearchmachine added v9.3.0 and removed v9.2.0 labels Oct 2, 2025

davidkyle added 3 commits October 3, 2025 11:06

Merge branch 'main' into fix-transform-upgrade

3714fc3

update version check

2de8125

ignore system indices

84329e4

prwhelan approved these changes Oct 6, 2025

View reviewed changes

davidkyle and others added 2 commits October 8, 2025 10:53

Merge branch 'main' into fix-transform-upgrade

68c1279

[CI] Auto commit changes from spotless

462aa3c

davidkyle merged commit 208ae57 into elastic:main Oct 8, 2025
34 checks passed

davidkyle mentioned this pull request Oct 10, 2025

[9.2] [ML] Fix and unmute Transform upgrade test (#132995) #136373

Merged

davidkyle mentioned this pull request Oct 10, 2025

[9.1] [ML] Fix and unmute Transform upgrade test (#132995) #136374

Merged

davidkyle mentioned this pull request Oct 10, 2025

[9.0] [ML] Fix and unmute Transform upgrade test (#132995) #136375

Merged

davidkyle mentioned this pull request Oct 10, 2025

[8.19] [ML] Fix and unmute Transform upgrade test (#132995) #136376

Merged

davidkyle mentioned this pull request Oct 10, 2025

[8.18] [ML] Fix and unmute Transform upgrade test (#132995) #136377

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ML] Fix Transform upgrade test #132995

[ML] Fix Transform upgrade test #132995

Uh oh!

davidkyle commented Aug 15, 2025

Uh oh!

elasticsearchmachine commented Aug 15, 2025

Uh oh!

davidkyle Aug 19, 2025

Uh oh!

prwhelan Oct 6, 2025

Uh oh!

Uh oh!

davidkyle commented Oct 3, 2025

Uh oh!

davidkyle commented Oct 6, 2025

Uh oh!

prwhelan Oct 6, 2025

Uh oh!

Uh oh!

davidkyle commented Oct 10, 2025

Uh oh!

Uh oh!

[ML] Fix Transform upgrade test #132995

[ML] Fix Transform upgrade test #132995

Uh oh!

Conversation

davidkyle commented Aug 15, 2025

Uh oh!

elasticsearchmachine commented Aug 15, 2025

Uh oh!

davidkyle Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

prwhelan Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidkyle commented Oct 3, 2025

Uh oh!

davidkyle commented Oct 6, 2025

Uh oh!

prwhelan Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidkyle commented Oct 10, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Uh oh!